You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
✅ All checks pass — ruff check and ruff format both passed with no issues.
Mypy
✅ No new type errors introduced. 4 pre-existing errors in shell_utils.py (unreachable statements, return type mismatch) are unrelated to this PR's changes.
Code Review
✅ No critical issues found. This is a clean, minimal change.
The PR adds errors='replace' to subprocess.run() kwargs when text=True in get_cross_platform_subprocess_run_args(). This prevents UnicodeDecodeError when subprocess output (e.g., pytest) contains non-UTF-8 bytes, replacing them with U+FFFD instead of crashing.
Previous review comments: Updated 2 stale comments that referenced files (parse_test_output.py, PrComment.py) no longer changed in this PR.
Test Coverage
File
Stmts (PR)
Miss (PR)
Cover (PR)
Cover (main)
Delta
codeflash/code_utils/shell_utils.py
157
61
61%
51%
+10%
✅ New lines 264-265 are covered by existing tests
ℹ️ Missing lines 267-270 are the Windows-specific branch (sys.platform == "win32") — expected on Linux CI
✅ Overall project coverage: 78% (no regression)
✅ No new files added
Last updated: 2026-02-25T17:10Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
No description provided.